From 5ddb85b24417405b65b1661f9a1a0c4442043f41 Mon Sep 17 00:00:00 2001
From: Bye <bye@byecorps.com>
Date: Sat, 22 Jun 2024 12:13:14 +0100
Subject: [PATCH] Fix issue with external basic logins

The alt text for the app icon passes null into htmlspecialchars, which is deprecated.
---
 login_external_basic.php | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/login_external_basic.php b/login_external_basic.php
index 2a1c68c..67149c1 100644
--- a/login_external_basic.php
+++ b/login_external_basic.php
@@ -111,7 +111,7 @@ login:
             <div id="connection_img">
                 <img src="<?= get_avatar_url($_SESSION['id']) ?>" alt="<?= htmlspecialchars($user['display_name']) ?>'s avatar" />
                 <span class="sep">×</span>
-                <img src="<?= $app['icon'] ?>" alt="<?= htmlspecialchars($user['title']) ?>'s avatar" />
+                <img src="<?= $app['icon'] ?>" alt="<?= htmlspecialchars($app['title']) ?>" />
             </div>
             <h1>Sign into <?= htmlspecialchars($app['title']) ?></h1>
             <p class="subtitle">Owned by <strong><?= htmlspecialchars( get_display_name($app['owner_id'], put_bcid_in_parenthesis: true) ) ?></strong></p>